fix(daemon): log gRPC Send() errors instead of silencing them#4169
Open
hklcf wants to merge 1 commit into
Open
fix(daemon): log gRPC Send() errors instead of silencing them#4169hklcf wants to merge 1 commit into
hklcf wants to merge 1 commit into
Conversation
StartNetworkQualityTest, StartSTUNTest, StartTailscalePing and SubscribeTailscaleStatus methods had ignored errors from server.Send() and provider.SubscribeTailscaleStatus. Log these errors so that failures in streaming operations are visible. Fixes SagerNet#4164
nekohasekai
force-pushed
the
testing
branch
2 times, most recently
from
2141845 to
b6c416b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Multiple gRPC server streaming methods in \daemon/started_service.go\ silently ignore errors from \server.Send():
When the client disconnects or the stream breaks, \Send()\ fails silently, and the server continues processing with no visibility.
Fix
Log the error from \server.Send()\ and \provider.SubscribeTailscaleStatus()\ so that streaming failures are visible in logs.
Related Issue
Fixes #4164